Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point in time assets db again #1361

Merged
merged 4 commits into from
Aug 2, 2016
Merged

Conversation

llllllllll
Copy link
Contributor

We are doing it this time!

There are 2 commits after the revert that should be reviewed now.

def __eq__(self, other):
return reduce(
getattr(self, attr) == getattr(other, attr)
for attr in self.__slots__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reduction correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, I will add a test for this.

@llllllllll llllllllll force-pushed the point-in-time-assets-db-again branch from f3f95a8 to 8499e86 Compare August 2, 2016 17:36
@llllllllll llllllllll force-pushed the point-in-time-assets-db-again branch from 8499e86 to 19ecb8d Compare August 2, 2016 18:32
@coveralls
Copy link

coveralls commented Aug 2, 2016

Coverage Status

Coverage decreased (-0.2%) to 85.363% when pulling 19ecb8d on point-in-time-assets-db-again into 5b9d2e2 on master.

@llllllllll llllllllll merged commit 74c4673 into master Aug 2, 2016
@llllllllll llllllllll deleted the point-in-time-assets-db-again branch August 2, 2016 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants